linux-kernel - [PATCH] NVMe: do not touch sq door bell if nvmeq has been suspended

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1454341324-21273-1-git-send-email-mail_weber_wang@163.com>
Date:	Mon,  1 Feb 2016 10:42:04 -0500
From:	Wenbo Wang <mail_weber_wang@....com>
To:	axboe@...com, keith.busch@...el.com
Cc:	linux-kernel@...r.kernel.org, Wenbo Wang <mail_weber_wang@....com>,
	Wenbo Wang <wenbo.wang@...blaze.com>,
	linux-nvme@...ts.infradead.org
Subject: [PATCH] NVMe: do not touch sq door bell if nvmeq has been suspended

If __nvme_submit_cmd races with nvme_dev_disable, nvmeq
could have been suspended and dev->bar could have been
unmapped. Do not touch sq door bell in this case.

Signed-off-by: Wenbo Wang <wenbo.wang@...blaze.com>
Reviewed-by: Wenwei Tao <wenwei.tao@...blaze.com>
CC: linux-nvme@...ts.infradead.org
---
 drivers/nvme/host/pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 8b1a725..2288712 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -325,7 +325,8 @@ static void __nvme_submit_cmd(struct nvme_queue *nvmeq,
 
 	if (++tail == nvmeq->q_depth)
 		tail = 0;
-	writel(tail, nvmeq->q_db);
+	if (likely(nvmeq->cq_vector >= 0))
+		writel(tail, nvmeq->q_db);
 	nvmeq->sq_tail = tail;
 }
 
-- 
1.8.3.1