linux-kernel - Re: [PATCH 0/4] introduce new put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160201171642.GC14091@mtj.duckdns.org>
Date:	Mon, 1 Feb 2016 12:16:42 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Roman Pen <roman.penyaev@...fitbricks.com>
Cc:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Dan Williams <dan.j.williams@...el.com>,
	Gi-Oh Kim <gi-oh.kim@...fitbricks.com>,
	Jens Axboe <axboe@...nel.dk>, Len Brown <len.brown@...el.com>,
	Ming Lei <tom.leiming@...il.com>, Pavel Machek <pavel@....cz>,
	Sagi Grimberg <sagig@...lanox.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 0/4] introduce new put_getdisk() call

On Mon, Feb 01, 2016 at 03:51:51PM +0100, Roman Pen wrote:
> Hello.
> 
> In this patchset in the first patch I fixed module reference leak inside
> blk-cgroup.c.  In other patches I switched to a new put_getdisk() call,
> which should be used if the disk was received by get_disk() or get_gendisk()
> functions, which internally increase module reference.
> 
> The idea is to avoid confusion in the future and to have symmetric calls:
> 
> 	alloc_disk() -> put_disk() [as it is done in all the block drivers]
> 
> and
> 
> 	get_gendisk() -> put_gendisk() [if you need to find a disk by minor,major]
> 
> The second sequence internally increases disk owner module reference on
> get and decreases it on put.

For the entire series,

 Acked-by: Tejun Heo <tj@...nel.org>

Nice catch, thanks!

-- 
tejun