linux-kernel - Re: [PATCH] PM / AVS: rockchip-io: add GRF and PMUGRF types to distinguish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 01 Feb 2016 22:17:22 +0100
From:	Heiko Stübner <heiko@...ech.de>
To:	"David.Wu" <wdc@...k-chips.com>
Cc:	David Wu <david.wu@...k-chips.com>, khilman@...nel.org, nm@...com,
	huangtao@...k-chips.com, cf@...k-chips.com, zyw@...k-chips.com,
	xjq@...k-chips.com, linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM / AVS: rockchip-io: add GRF and PMUGRF types to distinguish

Hi David,

Am Montag, 1. Februar 2016, 16:54:38 schrieb David.Wu:
> 在 2016/1/30 20:39, Heiko Stuebner 写道:
> > Am Samstag, 30. Januar 2016, 20:01:45 schrieb David Wu:
> >> As rk3368 contained two separated iodomain areas, this was
> >> determined to use which regmap base address.
> >> 
> >> Signed-off-by: David Wu <david.wu@...k-chips.com>
> > 
> > I don't think we need to specify this on a driver level. Both GRF areas
> > are
> > "General register files" only located in two separate power-domains.
> > So the rockchip,grf property should work for both. Especially as nothing
> > keeps designers from introducing yet another GRF-area somewhere else ;-)
> > 
> > >From when I started working on the rk3368, I still have a preliminary
> > 
> > patches for that sitting here, so I've attached on how I envisoned that to
> > work.
> 
> Okay, i agree to you, but it make someone a little confused just from
> the drive code,
> not DT file,  about  pmugrf regmap base address.:-)
> 
> How do you feel about intergating GRF and PMU drivers in one driver?
> Thanks!

I will very strongly disagree here ;-) .
Similar to the power-domains being part of the pmu, the io-domains are
part of their individual GRFs. So if you want it really clean and tidy the way 
to go foward will be the attached patches. Compile-tested only.

Other things like the usbphy control should move there as well in the long 
run. But that's not immediate necessary.


Heiko
View attachment "0001-PM-AVS-rockchip-io-make-io-domains-a-child-of-the-GR.patch" of type "text/x-patch" (2790 bytes)

View attachment "0003-arm64-dts-rockchip-add-rk3368-iodomains.patch" of type "text/x-patch" (1174 bytes)

View attachment "0002-arm64-dts-rockchip-make-grf-syscons-simple-mfds.patch" of type "text/x-patch" (1317 bytes)