linux-kernel - Re: [PATCH v6 4/5] videobuf2-dc: Let drivers specify DMA attrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=URO2kMHJD+XTMsWw29VjGAX43fgzi_s+FsyBrjJo8FgA@mail.gmail.com>
Date:	Mon, 1 Feb 2016 13:37:43 -0800
From:	Doug Anderson <dianders@...omium.org>
To:	Marek Szyprowski <m.szyprowski@...sung.com>
Cc:	Russell King <linux@....linux.org.uk>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Robin Murphy <robin.murphy@....com>,
	Tomasz Figa <tfiga@...omium.org>,
	Pawel Osciak <pawel@...iak.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Christoph Hellwig <hch@...radead.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Linux Media Mailing List <linux-media@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 4/5] videobuf2-dc: Let drivers specify DMA attrs

On Mon, Feb 1, 2016 at 5:29 AM, Marek Szyprowski
<m.szyprowski@...sung.com> wrote:
> Hello,
>
> On 2016-01-11 18:30, Douglas Anderson wrote:
>>
>> From: Tomasz Figa <tfiga@...omium.org>
>>
>> DMA allocations might be subject to certain reqiurements specific to the
>> hardware using the buffers, such as availability of kernel mapping (for
>> contents fix-ups in the driver). The only entity that knows them is the
>> driver, so it must share this knowledge with vb2-dc.
>>
>> This patch extends the alloc_ctx initialization interface to let the
>> driver specify DMA attrs, which are then stored inside the allocation
>> context and will be used for all allocations with that context.
>>
>> As a side effect, all dma_*_coherent() calls are turned into
>> dma_*_attrs() calls, because the attributes need to be carried over
>> through all DMA operations.
>>
>> Signed-off-by: Tomasz Figa <tfiga@...omium.org>
>> Signed-off-by: Douglas Anderson <dianders@...omium.org>
>
>
> Acked-by: Marek Szyprowski <m.szyprowski@...sung.com>

Added both your ans Mauro's acks to the current patch in RMK's patch
tracker.  You can see the patch at
<http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=8508/2>

Note that Javier has tested this series upstream on a Samsung
Chromebook and validated that the allocations are working as intended,
even if MFC is a bit tricky to get working properly upstream.


-Doug