linux-kernel - Re: [PATCH v2] ata: add AMD Seattle platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56AFD91F.4030008@amd.com>
Date:	Mon, 1 Feb 2016 16:15:59 -0600
From:	Brijesh Singh <brijesh.singh@....com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	<brijesh.singh@....com>, Tejun Heo <tj@...nel.org>,
	<linux-kernel@...r.kernel.org>, <hdegoede@...hat.com>,
	<linux-ide@...r.kernel.org>, Graeme Gregory <graeme@...a.org.uk>
Subject: Re: [PATCH v2] ata: add AMD Seattle platform driver

Hi,

> 
> This is where we really need the ACPI maintainers to explain the
> general policy for dealing with firmware updates.
> 
> I would assume that adding the feature in a later firmware version
> is a compatible change, and the feature is non-essential (the
> device will work fine with the generic SATA driver, except
> the LEDs don't blink), so it's not a big deal, it's just what
> you get for having the firmware shipped before the driver is
> reviewed (don't do that).
> 

Agreed, the driver should have been reviewed earlier. And now changes in firmware will also require
them changing other OSes drivers.

Just speaking my mind, maybe server folks will be fine without activity LED but I think "locate" and "fault" LEDs is needed.

-Brijesh

> 	Arnd
>