[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 2 Feb 2016 18:19:03 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Jiri Olsa <jolsa@...hat.com>
Cc: Namhyung Kim <namhyung@...nel.org>, Jiri Olsa <jolsa@...nel.org>,
lkml <linux-kernel@...r.kernel.org>,
David Ahern <dsahern@...il.com>,
Ingo Molnar <mingo@...nel.org>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 14/26] perf tools: Introduce struct perf_hpp_list
Em Mon, Jan 25, 2016 at 04:09:33PM +0100, Jiri Olsa escreveu:
> On Tue, Jan 26, 2016 at 12:00:46AM +0900, Namhyung Kim wrote:
>
> SNIP
>
> > > void perf_hpp__cancel_cumulate(void)
> > > diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h
> > > index f3bcf2d38733..a9c8ccfcc284 100644
> > > --- a/tools/perf/util/hist.h
> > > +++ b/tools/perf/util/hist.h
> > > @@ -226,20 +226,24 @@ struct perf_hpp_fmt {
> > > int idx;
> > > };
> > >
> > > -extern struct list_head perf_hpp__list;
> > > -extern struct list_head perf_hpp__sort_list;
> > > +struct perf_hpp_list {
> > > + struct list_head list;
> > > + struct list_head sort_list;
> > > +};
> >
> > What about this?
> >
> > struct perf_hpp_list {
> > struct list_head fields;
> > struct list_head sorts;
> > };
> >
> > This also aligns with the option names.
>
> yep, sounds better ;-)
Ok, did the change as I'm refreshing this series to merge it.
- Arnaldo
Powered by blists - more mailing lists