linux-kernel - Re: [PATCH] Staging: fix coding style in rtl8188eu/core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 02 Feb 2016 14:51:55 -0800
From:	Joe Perches <joe@...ches.com>
To:	Colin Vidal <colin@...dal.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Staging: fix coding style in rtl8188eu/core

On Tue, 2016-02-02 at 22:28 +0100, Colin Vidal wrote:
> On Tue, 2016-02-02 at 13:14 -0800, Joe Perches wrote:
> > On Tue, 2016-02-02 at 21:57 +0100, Colin Vidal wrote:
> > > Set constant on the left of the test, and jump a new line to avoid to
> > > exceed the 80 char length limit.
> > []
> > > diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c
[]
> > bool rtw_IOL_applied(struct adapter *adapter)
> > {
> > 	return adapter->registrypriv.fw_iol == 1 ||
> > 	       (adapter->registrypriv.fw_iol == 2 &&
> > 		!adapter_to_dvobj(adapter)->ishighspeed);
> > }
> > 
> 
> Oh, yeah, the second one is obviously finer. If I'm right, I should
> resend a new patch with a subject which looks something like "[PATCH
> v2] ... " ? 

correct.