linux-kernel - Re: [PATCH] Staging: fix coding style in rtl8188eu/core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 03 Feb 2016 00:04:15 +0100
From:	Colin Vidal <colin@...dal.org>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Staging: fix coding style in rtl8188eu/core

On Tue, 2016-02-02 at 23:54 +0100, Colin Vidal wrote:
> Set constant operand on right of test, and refactor the code in a
> more
> compact and readable way.
> 
> Signed-off-by: Colin Vidal <colin@...dal.org>
> ---
>  drivers/staging/rtl8188eu/core/rtw_iol.c | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c
> b/drivers/staging/rtl8188eu/core/rtw_iol.c
> index cdcf0ea..00e1136 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_iol.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_iol.c
> @@ -18,14 +18,11 @@
>   *
>  
> *********************************************************************
> *********/
>  
> -#include<rtw_iol.h>
> +#include <rtw_iol.h>
>  
> -bool rtw_IOL_applied(struct adapter  *adapter)
> +bool rtw_IOL_applied(struct adapter *adapter)
>  {
> -	if (1 == adapter->registrypriv.fw_iol)
> -		return true;
> -
> -	if ((2 == adapter->registrypriv.fw_iol) &&
> (!adapter_to_dvobj(adapter)->ishighspeed))
> -		return true;
> -	return false;
> +	return adapter->registrypriv.fw_iol == 1 ||
> +		(adapter->registrypriv.fw_iol == 2 &&
> +		 !adapter_to_dvobj(adapter)->ishighspeed);
>  }

Argh... The subject should be prefixed by "[PATCH v2]"... Missing
training, sorry.