linux-kernel - RE: [PATCH v7 02/14] scsi: ufs: clear fields UTRD, UPIU req and rsp before new transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B54164238@hasmsx108.ger.corp.intel.com>
Date:	Tue, 2 Feb 2016 10:07:26 +0000
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	Yaniv Gardi <ygardi@...eaurora.org>,
	"robherring2@...il.com" <robherring2@...il.com>,
	"James.Bottomley@...senPartnership.com" 
	<James.Bottomley@...senPartnership.com>,
	"pebolle@...cali.nl" <pebolle@...cali.nl>,
	"hch@...radead.org" <hch@...radead.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"santoshsy@...il.com" <santoshsy@...il.com>,
	"linux-scsi-owner@...r.kernel.org" <linux-scsi-owner@...r.kernel.org>,
	"subhashj@...eaurora.org" <subhashj@...eaurora.org>,
	"gbroner@...eaurora.org" <gbroner@...eaurora.org>,
	"draviv@...eaurora.org" <draviv@...eaurora.org>,
	Vinayak Holikatti <vinholikatti@...il.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>
Subject: RE: [PATCH v7 02/14] scsi: ufs: clear fields UTRD, UPIU req and rsp
 before new transfers



> Some of the data structures (like response UPIU) and/or its elements
> (unused fields) should be cleared before sending out the respective
> command to UFS device.
> 
> This change clears the UPIU response data structure for query commands
> and NOP command before sending out the command. We also initialize the
> PRDT table length to zero which should take care of commands which doesn't
> have any data associated with it. We are also clearing the unused fields in
> request UPIU for NOP command.
> 
> Reviewed-by: Gilad Broner <gbroner@...eaurora.org>
> Reviewed-by: Dolev Raviv <draviv@...eaurora.org>
> Signed-off-by: Subhash Jadavani <subhashj@...eaurora.org>
> Signed-off-by: Yaniv Gardi <ygardi@...eaurora.org>


You can add my ack and/or tested by (we have similar fix running in our code base for a long time :))

Thanks
Tomas