linux-kernel - Re: [Xen-devel] [PATCH 1/1] xen-netfront: uninitialized fields in xenvif_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 2 Feb 2016 10:25:37 +0000
From:	David Vrabel <david.vrabel@...rix.com>
To:	Dongli Zhang <dongli.zhang@...cle.com>, <ian.campbell@...rix.com>
CC:	<xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH 1/1] xen-netfront: uninitialized fields in
 xenvif_rx_action

On 02/02/16 06:20, Dongli Zhang wrote:
> While npo.copy and npo.meta are initialized in xenvif_rx_action, fields
> such as npo.meta_prod are directly used later in xenvif_gop_skb without
> being initialized first. Although the output of xenvif_rx_action is based
> on the difference between new npo->meta_prod and old npo->meta_prod, it is
> better to initialize them to 0 at the beginning.

Fields that are omitted from an initializer are initialized to zero.  So
this patch is not needed.

David

> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -560,6 +560,10 @@ static void xenvif_rx_action(struct xenvif_queue *queue)
>  	bool need_to_notify = false;
>  
>  	struct netrx_pending_operations npo = {
> +		.copy_prod = 0,
> +		.copy_cons = 0,
> +		.meta_prod = 0,
> +		.meta_cons = 0,
>  		.copy  = queue->grant_copy_op,
>  		.meta  = queue->meta,
>  	};
>