linux-kernel - Re: [PATCH] cputime: Fix timeval/timespec-->cputime conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 02 Feb 2016 13:53:01 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	zengtao <prime.zeng@...wei.com>
Cc:	tglx@...utronix.de, fweisbec@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cputime: Fix timeval/timespec-->cputime conversion

On Tuesday 02 February 2016 11:38:34 zengtao wrote:
> The datatype __kernel_time_t is u32 on 32bit platform,
> it will easily get overflow, so force u64 conversion.
> 
> Currently the following function will be affected:
> 1. setitimer()
> 2. timer_create/timer_settime()
> 3. sys_clock_nanosleep
> And this will occur on MIPS32 and ARM32 with "Full dynticks CPU
> time accounting" enabled, which is required for CONFIG_NO_HZ_FULL.
> 
> Signed-off-by: zengtao <prime.zeng@...wei.com>
> 

The patch looks good now, but please add a line saying

Fixes: 31c1fc818715 ("ARM: Kconfig: allow full nohz CPU accounting")

below your Signed-off-by, so everyone can figure out whether they
need this backported or not.

Reviewed-by: Arnd Bergmann <arnd@...db.de>

Thomas, do you want to take this through the tip tree?