linux-kernel - Re: [PATCH] mmc: pxamci: fix again read-only gpio detection polarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 2 Feb 2016 14:11:12 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"# 4.0+" <stable@...r.kernel.org>
Subject: Re: [PATCH] mmc: pxamci: fix again read-only gpio detection polarity

On 29 January 2016 at 00:21, Robert Jarzmik <robert.jarzmik@...e.fr> wrote:
> The commit fixing the conversion of pxamci to slot-gpio API fixed the
> inverted the logic of the read-only gpio. Unfortunately, the commit was
> tested on a non-inverted gpio, and not on the inverted one. And the fix
> did work partially, by luck.
>
> This is the remaining missing part of the fix, trivial but still necessary.
>
> Fixes: Fixes: 26d49fe71953 ("mmc: pxamci: fix read-only gpio detection polarity")
> Reported-by: Andrea Adami <andrea.adami@...il.com>
> Tested-by: Andrea Adami <andrea.adami@...il.com>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@...e.fr>
> Cc: stable@...r.kernel.org

Thanks, applied for fixes!

Kind regards
Uffe

> ---
>  drivers/mmc/host/pxamci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
> index ce08896b9d69..28a057fae0a1 100644
> --- a/drivers/mmc/host/pxamci.c
> +++ b/drivers/mmc/host/pxamci.c
> @@ -804,7 +804,7 @@ static int pxamci_probe(struct platform_device *pdev)
>                 dev_err(&pdev->dev, "Failed requesting gpio_ro %d\n", gpio_ro);
>                 goto out;
>         } else {
> -               mmc->caps |= host->pdata->gpio_card_ro_invert ?
> +               mmc->caps2 |= host->pdata->gpio_card_ro_invert ?
>                         0 : MMC_CAP2_RO_ACTIVE_HIGH;
>         }
>
> --
> 2.1.4
>