[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 2 Feb 2016 14:11:34 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Jisheng Zhang <jszhang@...vell.com>
Cc: Ludovic Desroches <ludovic.desroches@...el.com>,
linux-mmc <linux-mmc@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] mmc: sdhci-of-at91: fix pm runtime unbalanced issue in
error path
On 2 February 2016 at 12:55, Jisheng Zhang <jszhang@...vell.com> wrote:
> The device power usage counter is increased by pm_runtime_get_noresume
> but isn't decreased in err_add_host error path.
>
> Fix this issue by calling pm_runtime_put_noidle() in the error path to
> restore the device's power usage counter.
>
> Signed-off-by: Jisheng Zhang <jszhang@...vell.com>
> Acked-by: Ludovic Desroches <ludovic.desroches@...el.com>
> Fixes: f5f17813ae9b ("mmc: sdhci-of-at91: add PM support)
Thanks, applied for fixes!
Kind regards
Uffe
> ---
> Since v1:
> - Add Ludovic ack
> - address Ulf's comment
>
> drivers/mmc/host/sdhci-of-at91.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
> index 7db7163..35c02fc 100644
> --- a/drivers/mmc/host/sdhci-of-at91.c
> +++ b/drivers/mmc/host/sdhci-of-at91.c
> @@ -211,6 +211,7 @@ static int sdhci_at91_probe(struct platform_device *pdev)
> pm_runtime_disable:
> pm_runtime_disable(&pdev->dev);
> pm_runtime_set_suspended(&pdev->dev);
> + pm_runtime_put_noidle(&pdev->dev);
> clocks_disable_unprepare:
> clk_disable_unprepare(priv->gck);
> clk_disable_unprepare(priv->mainck);
> --
> 1.9.1
>
Powered by blists - more mailing lists