linux-kernel - Re: [PATCH] treewide: Use 'sizeof(x)' instead of 'sizeof x'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 02 Feb 2016 05:58:56 -0800
From:	Joe Perches <joe@...ches.com>
To:	Ingo Molnar <mingo@...nel.org>,
	Wei Tang <tangwei@...s.chinamobile.com>
Cc:	akpm@...ux-foundation.org, peterz@...radead.org, tj@...rnel.org,
	kirill.shutemov@...ux.intel.com, jason.low2@...com,
	xypron.glpk@....de, oleg@...hat.com, koct9i@...il.com,
	josh@...htriplett.org, ebiederm@...ssion.com, cyphar@...har.com,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] treewide: Use 'sizeof(x)' instead of 'sizeof x'

On Tue, 2016-02-02 at 12:28 +0100, Ingo Molnar wrote:
> * Ingo Molnar <mingo@...nel.org> wrote:
> 
> > If anyone feels strongly about accepting such patches, then the right solution 
> > is to create a Coccinelle semantic patch to run over the whole kernel and get 
> > over with the churn once and for all.
> 
> So applying a semantic patch like this to all .c files:
> 
>   @@ expression E; @@
>   -sizeof E
>   +sizeof(E)
>   @@ expression E2; @@
>   -sizeof((E2))
>   +sizeof(E2)
> 
> Produces the single patch below for the whole kernel - instead of generating a 
> churn of 1,000+ patches ...

If this isn't a joke, a nicer way to submit this is
by subsystem and not as a single huge patch.

This allows subsystem maintainers to reduce patch
contention as this patch already doesn't apply
to -next.