linux-kernel - Re: [PATCH] EDAC, mpc85xx: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Feb 2016 16:09:50 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Johannes Thumshirn <jthumshirn@...e.de>,
	Guenter Roeck <linux@...ck-us.net>,
	Johannes Thumshirn <morbidrsa@...il.com>,
	Doug Thompson <dougthompson@...ssion.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org
Subject: Re: [PATCH] EDAC, mpc85xx: fix build warning

On Tue, Feb 02, 2016 at 08:25:54PM +0530, Sudip Mukherjee wrote:
> oops... i just sent the v2 while removing pvr. Which is the better way
> then?
> Personally, I donot like __maybe_unused, it is telling gcc that this
> variable is unused so donot give any warning for it. But in reality it
> is being used in some cases.

And? You want to shut up the warning, right?

Adding __maybe_unused is the simplest variant without disadvantages. Or
are there any?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.