linux-kernel - Re: [Xen-devel] [PATCH v2 09/11] xen/hvmlite: Use x86's default timer init for HVMlite guests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Feb 2016 16:27:09 +0000
From:	David Vrabel <david.vrabel@...rix.com>
To:	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	<david.vrabel@...rix.com>, <konrad.wilk@...cle.com>
CC:	<xen-devel@...ts.xenproject.org>, <mcgrof@...e.com>,
	<linux-kernel@...r.kernel.org>, <roger.pau@...rix.com>
Subject: Re: [Xen-devel] [PATCH v2 09/11] xen/hvmlite: Use x86's default timer
 init for HVMlite guests

On 01/02/16 15:38, Boris Ostrovsky wrote:
> xen_timer_init() will be called from apic_bsp_setup().

I must be missing something because xen_init_time_ops() is only called
from the PV-only xen_start_kernel()?

David

> --- a/arch/x86/xen/time.c
> +++ b/arch/x86/xen/time.c
> @@ -492,7 +492,10 @@ void __init xen_init_time_ops(void)
>  {
>  	pv_time_ops = xen_time_ops;
>  
> -	x86_init.timers.timer_init = xen_time_init;
> +	if (!xen_hvmlite)
> +		x86_init.timers.timer_init = xen_time_init;
> +	else
> +		x86_init.timers.timer_init = x86_init_noop;
>  	x86_init.timers.setup_percpu_clockev = x86_init_noop;
>  	x86_cpuinit.setup_percpu_clockev = x86_init_noop;
>  
>