linux-kernel - Re: [PATCH v6] kernel: add kcov code coverage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Feb 2016 18:19:44 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	Dmitry Vyukov <dvyukov@...gle.com>, syzkaller@...glegroups.com,
	vegard.nossum@...cle.com, catalin.marinas@....com,
	taviso@...gle.com, will.deacon@....com,
	linux-kernel@...r.kernel.org, quentin.casasnovas@...cle.com,
	kcc@...gle.com, edumazet@...gle.com, glider@...gle.com,
	keescook@...gle.com, bhelgaas@...gle.com, sasha.levin@...cle.com,
	akpm@...ux-foundation.org, drysdale@...gle.com,
	linux-arm-kernel@...ts.infradead.org, ard.biesheuvel@...aro.org,
	ryabinin.a.a@...il.com, kirill@...temov.name
Subject: Re: [PATCH v6] kernel: add kcov code coverage

On 01/25/2016, 02:00 PM, Dmitry Vyukov wrote:
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -136,6 +136,12 @@ _c_flags += $(if $(patsubst n%,, \
>  		$(CFLAGS_UBSAN))
>  endif
>  
> +ifeq ($(CONFIG_KCOV),y)
> +_c_flags += $(if $(patsubst n%,, \
> +	$(KCOV_INSTRUMENT_$(basetarget).o)$(KCOV_INSTRUMENT)y), \
> +	$(CFLAGS_KCOV))

Now that KCOV does not inherit KASAN's "n"s, I see link errors in efi
lib with EFI_STUB:
drivers/firmware/efi/libstub/lib.a(efi-stub-helper.o): In function
`efi_printk':
efi-stub-helper.c:(.text+0x13): undefined reference to
`__sanitizer_cov_trace_pc'
efi-stub-helper.c:(.text+0x31): undefined reference to
`__sanitizer_cov_trace_pc'
...

I fixed it by adding "KCOV_INSTRUMENT := n" to
  drivers/firmware/efi/libstub/Makefile

thanks,
-- 
js
suse labs