linux-kernel - Re: [PATCH v2 0/5] alienware-wmi new platform and feature support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Feb 2016 09:39:27 -0800
From:	Darren Hart <dvhart@...radead.org>
To:	Mario Limonciello <mario_limonciello@...l.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v2 0/5] alienware-wmi new platform and feature support

On Mon, Feb 01, 2016 at 08:28:46PM -0600, Mario Limonciello wrote:
> I've got some extensions for the alienware-wmi driver that have
> been introduced for a few new platforms and can be controlled via the WMI
> interface.
> 
> Changes from V1:
>  - Make sure whitespace changes are in their own patch
>  - Add commit descriptions to all patches
>  - Allow one line to go over 80 characters in deep sleep control patch
>    Other patches may have some areas that avoid going over 80 characters
>    still, but this matches the style of the existing driver.  If you would
>    like these to go over 80 characters as well, please comment which areas
>    this is OK.

This made it much easier to review. Thank you Mario. A few changes requested,
and a couple questions for you regarding intent/best-practice.

Thanks!

-- 
Darren Hart
Intel Open Source Technology Center