lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Feb 2016 10:13:53 -0800 From: Kamal Mostafa <kamal@...onical.com> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org, kernel-team@...ts.ubuntu.com Cc: Al Viro <viro@...iv.linux.org.uk>, Kent Overstreet <kmo@...erainc.com>, Jens Axboe <axboe@...com>, Kamal Mostafa <kamal@...onical.com> Subject: [PATCH 3.13.y-ckt 038/136] bcache: fix a leak in bch_cached_dev_run() 3.13.11-ckt34 -stable review patch. If anyone has any objections, please let me know. ---8<------------------------------------------------------------ From: Al Viro <viro@...IV.linux.org.uk> commit 4d4d8573a8451acc9f01cbea24b7e55f04a252fe upstream. Signed-off-by: Al Viro <viro@...iv.linux.org.uk> Tested-by: Joshua Schmid <jschmid@...e.com> Tested-by: Eric Wheeler <bcache@...ux.ewheeler.net> Cc: Kent Overstreet <kmo@...erainc.com> Signed-off-by: Jens Axboe <axboe@...com> Signed-off-by: Kamal Mostafa <kamal@...onical.com> --- drivers/md/bcache/super.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 85a1d79..0dfe7ba 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -863,8 +863,11 @@ void bch_cached_dev_run(struct cached_dev *dc) buf[SB_LABEL_SIZE] = '\0'; env[2] = kasprintf(GFP_KERNEL, "CACHED_LABEL=%s", buf); - if (atomic_xchg(&dc->running, 1)) + if (atomic_xchg(&dc->running, 1)) { + kfree(env[1]); + kfree(env[2]); return; + } if (!d->c && BDEV_STATE(&dc->sb) != BDEV_STATE_NONE) { -- 1.9.1
Powered by blists - more mailing lists