| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 3 Feb 2016 17:47:53 +0000
From: Mark Brown <broonie@...nel.org>
To: "Yang, Wenyou" <Wenyou.Yang@...el.com>
Cc: Javier Martinez Canillas <javier@...hile0.org>,
Liam Girdwood <lgirdwood@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Krzysztof Kozlowski <k.kozlowski@...sung.com>,
Lee Jones <lee.jones@...aro.org>,
Peter Korsgaard <jacmet@...il.com>,
"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] regulator: act8945a: add regulator driver for
ACT8945A
On Wed, Feb 03, 2016 at 02:33:11AM +0000, Yang, Wenyou wrote:
> > I would just remove the "active-semi,act8945a-regulator" node and make "active-
> > semi,vsel-high" a property of the "active-semi,act8945a" node.
> > That way you can remove the mfd cell .of_compatible and OF table in the
> > regulator driver and read the "active-semi,vsel-high" using the platform device's
> > parent of_node.
> > But it's better if you wait for Mark's opinions before re-spining your patches.
> Hi Mark, what is your opinions?
Like Javier says you should make your DT binding look like the DT
bindings for other MFDs and not use of_compatible.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists