linux-kernel - Re: [PATCH] ext4: add a line break for proc mb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 03 Feb 2016 10:30:32 -0800
From:	Joe Perches <joe@...ches.com>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>,
	Huaitong Han <huaitong.han@...el.com>
Cc:	tytso@....edu, adilger.kernel@...ger.ca,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: add a line break for proc mb_groups display

On Wed, 2016-02-03 at 10:13 -0800, Darrick J. Wong wrote:
> On Wed, Feb 03, 2016 at 09:19:06PM +0800, Huaitong Han wrote:
> > This patch adds a line break for proc mb_groups display.

Using 2 lines for output might break any existing users.

Are there any?

> > 
> > Signed-off-by: Huaitong Han <huaitong.han@...el.com>
> > ---
> >  fs/ext4/mballoc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> > index 61eaf74..4424b7b 100644
> > --- a/fs/ext4/mballoc.c
> > +++ b/fs/ext4/mballoc.c
> > @@ -2285,7 +2285,7 @@ static int ext4_mb_seq_groups_show(struct seq_file *seq, void *v)
> >  	if (group == 0)
> >  		seq_puts(seq, "#group: free  frags first ["
> >  			      " 2^0   2^1   2^2   2^3   2^4   2^5   2^6  "
> > -			      " 2^7   2^8   2^9   2^10  2^11  2^12  2^13  ]");
> > +			      " 2^7   2^8   2^9   2^10  2^11  2^12  2^13  ]\n");
> 
> Oh, heh.
> 
> Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>
> 
> --D
> 
> >  
> >  	i = (sb->s_blocksize_bits + 2) * sizeof(sg.info.bb_counters[0]) +
> >  		sizeof(struct ext4_group_info);