linux-kernel - Re: [PATCH V13 08/10] dma: qcom_hidma: read the channel id from HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160203183650.GI1234@leverpostej>
Date:	Wed, 3 Feb 2016 18:36:50 +0000
From:	Mark Rutland <mark.rutland@....com>
To:	Sinan Kaya <okaya@...eaurora.org>
Cc:	dmaengine@...r.kernel.org, marc.zyngier@....com,
	timur@...eaurora.org, devicetree@...r.kernel.org,
	cov@...eaurora.org, vinod.koul@...el.com, jcm@...hat.com,
	shankerd@...eaurora.org, vikrams@...eaurora.org,
	eric.auger@...aro.org, agross@...eaurora.org, arnd@...db.de,
	linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V13 08/10] dma: qcom_hidma: read the channel id from HW

On Wed, Feb 03, 2016 at 01:32:01PM -0500, Sinan Kaya wrote:
> Hi Mark,
> 
> On 2/1/2016 10:35 AM, Mark Rutland wrote:
> >> Removing the flexibility to choose the event channel as there is no real
> >> > use case right now. We have been using the values in ACPI that match the HW
> >> > defaults. OS is reading the event-channel from the HW register now.
> > Fold this in to the patches adding the binding and the driver.
> > 
> > There is no reason to add this then remove it within the same series.
> > 
> > Mark.
> > 
> 
> Before I post the next rev, I'd like to see if I missed something in the series when 
> it comes to your comments. 
> 
> Can you please take a look and let me know?

Sorry, but it's going to be far easier to review with useless code
removed, so I will wait until the next posting where this patch is
folded in.

Thanks,
Mark.