linux-kernel - Re: [PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56B16F20.70104@osg.samsung.com>
Date:	Wed, 3 Feb 2016 00:08:16 -0300
From:	Javier Martinez Canillas <javier@....samsung.com>
To:	Laxman Dewangan <ldewangan@...dia.com>, lee.jones@...aro.org,
	alexandre.belloni@...e-electrons.com, k.kozlowski@...sung.com
Cc:	cw00.choi@...sung.com, linux-kernel@...r.kernel.org,
	rtc-linux@...glegroups.com
Subject: Re: [PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers

Hello Laxman

On 02/02/2016 10:16 AM, Laxman Dewangan wrote:
> rtc_regmap should be used to access all RTC regsiters instead

s/regsiters/registers

> of parent regmap regardless of what chip or property have it.
>
> This makes the register access uniform and extendible for other
> chips.
>
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> CC: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> CC: Javier Martinez Canillas <javier@....samsung.com>
> ---
>   drivers/rtc/rtc-max77686.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>

Thanks for the patch, I indeed should had used rtc_regmap for consistency.

Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America