linux-kernel - Re: [PATCH net-next] hv_netvsc: Add feature flags NETIF_F_IPV6_CSUM and NETIF_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 3 Feb 2016 12:02:04 -0800
From:	Tom Herbert <tom@...bertland.com>
To:	Simon Xiao <sixiao@...rosoft.com>
Cc:	"K. Y. Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	devel@...uxdriverproject.org,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] hv_netvsc: Add feature flags NETIF_F_IPV6_CSUM
 and NETIF_F_TSO6 for netvsc

On Wed, Feb 3, 2016 at 1:30 PM, Simon Xiao <sixiao@...rosoft.com> wrote:
> 1. Adding NETIF_F_IPV6_CSUM and NETIF_F_TSO6 feature flags which are
> supported by Hyper-V platform.

NETIF_F_IPV6_CSUM and NETIF_F_IP_CSUM are being deprecated. Please
change to use NETIF_F_HW_CSUM (calling helper functions if need).

Thanks,
Tom

> 2. Cleanup the coding style of flag assignment by using macro.
>
> Signed-off-by: Simon Xiao <sixiao@...rosoft.com>
> Reviewed-by: K. Y. Srinivasan <kys@...rosoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> ---
>  drivers/net/hyperv/netvsc_drv.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 1d3a665..0cde741 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -43,6 +43,12 @@
>
>  #define RING_SIZE_MIN 64
>  #define LINKCHANGE_INT (2 * HZ)
> +#define NETVSC_HW_FEATURES     (NETIF_F_RXCSUM | \
> +                                NETIF_F_SG | \
> +                                NETIF_F_TSO | \
> +                                NETIF_F_TSO6 | \
> +                                NETIF_F_IP_CSUM | \
> +                                NETIF_F_IPV6_CSUM)
>  static int ring_size = 128;
>  module_param(ring_size, int, S_IRUGO);
>  MODULE_PARM_DESC(ring_size, "Ring buffer size (# of pages)");
> @@ -1081,10 +1087,8 @@ static int netvsc_probe(struct hv_device *dev,
>
>         net->netdev_ops = &device_ops;
>
> -       net->hw_features = NETIF_F_RXCSUM | NETIF_F_SG | NETIF_F_IP_CSUM |
> -                               NETIF_F_TSO;
> -       net->features = NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_SG | NETIF_F_RXCSUM |
> -                       NETIF_F_IP_CSUM | NETIF_F_TSO;
> +       net->hw_features = NETVSC_HW_FEATURES;
> +       net->features = NETVSC_HW_FEATURES | NETIF_F_HW_VLAN_CTAG_TX;
>
>         net->ethtool_ops = &ethtool_ops;
>         SET_NETDEV_DEV(net, &dev->device);
> --
> 2.5.0
>