linux-kernel - Re: [PATCH] scripts/sign-file.c: Add support for signing with a raw signature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14231.1454532331@warthog.procyon.org.uk>
Date:	Wed, 03 Feb 2016 20:45:31 +0000
From:	David Howells <dhowells@...hat.com>
To:	Juerg Haefliger <juerg.haefliger@....com>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org,
	keyrings@...r.kernel.org, dwmw2@...radead.org
Subject: Re: [PATCH] scripts/sign-file.c: Add support for signing with a raw signature

In the patched file, I see:

	if (!raw_sig) {
	...
	}

	if (!raw_sig && save_sig) {
	...
	}

	if (!raw_sig && sign_only) {
	...
	}

Can you just merge the three into one if-statement that is conditional on
!raw_sig with conditional bits inside?  It might be worth moving the contents
out to its own function, but it deals with sufficient of main's context that
it might not actually be worthwhile.

David