linux-kernel - Re: [PATCH] mm/debug-pagealloc: add missing debug_pagealloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 03 Feb 2016 23:51:17 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Laura Abbott <labbott@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-arm-kernel@...ts.infradead.org,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Christoph Lameter <cl@...ux.com>,
	Pekka Enberg <penberg@...nel.org>,
	David Rientjes <rientjes@...gle.com>,
	Jesper Dangaard Brouer <brouer@...hat.com>,
	Laura Abbott <labbott@...oraproject.org>, linux-mm@...ck.org,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Michal Hocko <mhocko@...e.com>,
	Vlastimil Babka <vbabka@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled

On Wednesday 03 February 2016 14:30:09 Laura Abbott wrote:
> On 02/03/2016 02:15 PM, Arnd Bergmann wrote:
> > The change to move the pagealloc logic broke the slab allocator
> > check when it's disabled at compile time:
> >
> > mm/slab.c: In function 'is_debug_pagealloc_cache':
> > mm/slab.c:1608:29: error: implicit declaration of function 'debug_pagealloc_enabled' [-Werror=implicit-function-declaration]
> >
> > This adds an inline helper to get it to work again.
> >
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Fixes: 0a244aea1a61 ("mm/slab: clean up DEBUG_PAGEALLOC processing code")
> > ---
> >   include/linux/mm.h | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > index 5d86eb2e8584..90d600ce56ad 100644
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
> > @@ -2242,6 +2242,7 @@ kernel_map_pages(struct page *page, int numpages, int enable)
> >   extern bool kernel_page_present(struct page *page);
> >   #endif /* CONFIG_HIBERNATION */
> >   #else
> > +static inline bool debug_pagealloc_enabled(void) { return 0; }
> >   static inline void
> >   kernel_map_pages(struct page *page, int numpages, int enable) {}
> >   #ifdef CONFIG_HIBERNATION
> >
> 
> I believe this should be fixed with http://article.gmane.org/gmane.linux.kernel.mm/145655

Yes, Christian's version looks nicer too (correct return type).

Thanks,

	Arnd