linux-kernel - Re: [PATCH] vsprintf: automatic parameters for %pIS via 'a'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9qvqKKYkd1QhRN6W-yTmJatd7AzuXBogTcb30sqKiUvaw@mail.gmail.com>
Date:	Thu, 4 Feb 2016 00:25:17 +0100
From:	"Jason A. Donenfeld" <Jason@...c4.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Daniel Borkmann <daniel@...earbox.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	andriy.shevchenko@...ux.intel.com,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vsprintf: automatic parameters for %pIS via 'a'

On Thu, Feb 4, 2016 at 12:05 AM, Joe Perches <joe@...ches.com> wrote:
>
> Doesn't this needs the mask tested?
>
>                 sa->sin6_flowinfo & IPV6_FLOWINFO_MASK

Good catch. Fixing and will submit another.

>
> given the use of bool, the != 0 are unnecessary.

True.

> Other than that, looks good to me.

Great!