linux-kernel - Re: [PATCH] staging: android: ion: use the manged version of DMA memory allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201602031317.T5nvNLln%fengguang.wu@intel.com>
Date:	Wed, 3 Feb 2016 13:49:54 +0800
From:	kbuild test robot <lkp@...el.com>
To:	"Gujulan Elango, Hari Prasath (H.)" <hgujulan@...teon.com>
Cc:	kbuild-all@...org,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"arve@...roid.com" <arve@...roid.com>,
	"riandrews@...roid.com" <riandrews@...roid.com>,
	"robin.murphy@....com" <robin.murphy@....com>,
	"tixy@...aro.org" <tixy@...aro.org>,
	"sriram@...irs.net.in" <sriram@...irs.net.in>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: android: ion: use the manged version of DMA
 memory allocation

Hi Hari,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.5-rc2 next-20160202]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Gujulan-Elango-Hari-Prasath-H/staging-android-ion-use-the-manged-version-of-DMA-memory-allocation/20160203-132744
config: x86_64-randconfig-x009-201605 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/staging/android/ion/ion_cma_heap.c: In function 'ion_cma_free':
>> drivers/staging/android/ion/ion_cma_heap.c:94:17: warning: unused variable 'dev' [-Wunused-variable]
     struct device *dev = cma_heap->dev;
                    ^

vim +/dev +94 drivers/staging/android/ion/ion_cma_heap.c

349c9e13 Benjamin Gaignard 2013-12-13   78  		goto free_table;
349c9e13 Benjamin Gaignard 2013-12-13   79  	/* keep this for memory release */
349c9e13 Benjamin Gaignard 2013-12-13   80  	buffer->priv_virt = info;
349c9e13 Benjamin Gaignard 2013-12-13   81  	dev_dbg(dev, "Allocate buffer %p\n", buffer);
349c9e13 Benjamin Gaignard 2013-12-13   82  	return 0;
349c9e13 Benjamin Gaignard 2013-12-13   83  
349c9e13 Benjamin Gaignard 2013-12-13   84  free_table:
349c9e13 Benjamin Gaignard 2013-12-13   85  	kfree(info->table);
349c9e13 Benjamin Gaignard 2013-12-13   86  err:
349c9e13 Benjamin Gaignard 2013-12-13   87  	kfree(info);
349c9e13 Benjamin Gaignard 2013-12-13   88  	return ION_CMA_ALLOCATE_FAILED;
349c9e13 Benjamin Gaignard 2013-12-13   89  }
349c9e13 Benjamin Gaignard 2013-12-13   90  
349c9e13 Benjamin Gaignard 2013-12-13   91  static void ion_cma_free(struct ion_buffer *buffer)
349c9e13 Benjamin Gaignard 2013-12-13   92  {
349c9e13 Benjamin Gaignard 2013-12-13   93  	struct ion_cma_heap *cma_heap = to_cma_heap(buffer->heap);
349c9e13 Benjamin Gaignard 2013-12-13  @94  	struct device *dev = cma_heap->dev;
349c9e13 Benjamin Gaignard 2013-12-13   95  	struct ion_cma_buffer_info *info = buffer->priv_virt;
349c9e13 Benjamin Gaignard 2013-12-13   96  
349c9e13 Benjamin Gaignard 2013-12-13   97  	/* release sg table */
349c9e13 Benjamin Gaignard 2013-12-13   98  	sg_free_table(info->table);
349c9e13 Benjamin Gaignard 2013-12-13   99  	kfree(info->table);
349c9e13 Benjamin Gaignard 2013-12-13  100  	kfree(info);
349c9e13 Benjamin Gaignard 2013-12-13  101  }
349c9e13 Benjamin Gaignard 2013-12-13  102  

:::::: The code at line 94 was first introduced by commit
:::::: 349c9e13855109df99c5205a4e8d53d9fa169490 gpu: ion: add CMA heap

:::::: TO: Benjamin Gaignard <benjamin.gaignard@...aro.org>
:::::: CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (25532 bytes)