linux-kernel - Re: [PATCH] lightnvm: invalidate addresses on multipage fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <321A48AE-5FAC-432A-A070-54C31DED65D8@lightnvm.io>
Date:	Wed, 3 Feb 2016 09:15:15 +0100
From:	Javier González <jg@...htnvm.io>
To:	Matias Bjørling <mb@...htnvm.io>
Cc:	linux-kernel@...r.kernel.org, linux-block@...r.kernel.org
Subject: Re: [PATCH] lightnvm: invalidate addresses on multipage fail

> 
> On 03 Feb 2016, at 09:10, Matias Bjørling <mb@...htnvm.io> wrote:
> 
> On 02/01/2016 02:10 PM, Javier González wrote:
>> If a page mapping fails when mapping several pages in a single write bio
>> request, make sure that already mapped pages are invalidated. Since
>> other legit mappings coming from a different bio request might have
>> occurred, rolling back the failed bio is a difficult, unnecessary
>> overhead; in part because when a mapping fails something bad has
>> happened already. Still, invalidating pages in the failed bio will help
>> GC.
>> 
>> Signed-off-by: Javier González <javier@...xlabs.com>
>> ---
>> drivers/lightnvm/rrpc.c | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
>> index c4d0b04..29befe9 100644
>> --- a/drivers/lightnvm/rrpc.c
>> +++ b/drivers/lightnvm/rrpc.c
>> @@ -730,6 +730,7 @@ static int rrpc_read_ppalist_rq(struct rrpc *rrpc, struct bio *bio,
>> 		} else {
>> 			BUG_ON(is_gc);
>> 			rrpc_unlock_laddr(rrpc, r);
>> +			rrpc_invalidate_range(rrpc, laddr, i + 1);
>> 			nvm_dev_dma_free(rrpc->dev, rqd->ppa_list,
>> 							rqd->dma_ppa_list);
>> 			return NVM_IO_DONE;
> 
> I'm not sure I understand this. This is in the read path, why would it
> need to invalidate pages if a page is not mapped?

You are right. I sent the wrong patch. I’ll send the right one now.

Javier

Download attachment "signature.asc" of type "application/pgp-signature" (843 bytes)