linux-kernel - Re: [PATCH] hpet: drop stale link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 3 Feb 2016 11:53:07 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Clemens Ladisch <clemens@...isch.de>,
	Jonathan Corbet <corbet@....net>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-doc@...r.kernel.org
Subject: Re: [PATCH] hpet: drop stale link


* Michael S. Tsirkin <mst@...hat.com> wrote:

> Looks like the HPET spec at intel.com got moved.
> It isn't hard to find so drop the link, just mention
> the revision assumed.
> 
> Suggested-by: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> ---
>  drivers/char/hpet.c           | 2 +-
>  Documentation/timers/hpet.txt | 2 +-
>  arch/x86/Kconfig              | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
> index 240b6cf..86c5f4d 100644
> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -42,7 +42,7 @@
>  /*
>   * The High Precision Event Timer driver.
>   * This driver is closely modelled after the rtc.c driver.
> - * http://www.intel.com/hardwaredesign/hpetspec_1.pdf
> + * http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
>   */
>  #define	HPET_USER_FREQ	(64)
>  #define	HPET_DRIFT	(500)
> diff --git a/Documentation/timers/hpet.txt b/Documentation/timers/hpet.txt
> index 767392f..f24e978 100644
> --- a/Documentation/timers/hpet.txt
> +++ b/Documentation/timers/hpet.txt
> @@ -3,7 +3,7 @@
>  The High Precision Event Timer (HPET) hardware follows a specification
>  by Intel and Microsoft which can be found at
>  
> -	http://www.intel.com/hardwaredesign/hpetspec_1.pdf
> +http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
>  
>  Each HPET has one fixed-rate counter (at 10+ MHz, hence "High Precision")
>  and up to 32 comparators.  Normally three or more comparators are provided,
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 9af2e63..f32faba 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -778,7 +778,7 @@ config HPET_TIMER
>  	  The HPET provides a stable time base on SMP
>  	  systems, unlike the TSC, but it is more expensive to access,
>  	  as it is off-chip.  You can find the HPET spec at
> -	  <http://www.intel.com/hardwaredesign/hpetspec_1.pdf>.
> +	  <http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf>.
>  
>  	  You can safely choose Y here.  However, HPET will only be
>  	  activated if the platform and the BIOS support this feature.

In fact we can also remove the link from this Kconfig entry, as it's highly 
unlikely that a user doing kernel configuration would want to start reading a 
spec.

Thanks,

	Ingo