linux-kernel - Re: [PATCH] dmaengine: use phys_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXe8i2JbhOP2sWkVkqHEeBnW4AfVBbRaoZW=Kg0s_9m3g@mail.gmail.com>
Date:	Wed, 3 Feb 2016 12:17:24 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Lee Jones <lee.jones@...aro.org>, dmaengine@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Niklas Söderlund <niklas.soderlund@...natech.se>
Subject: Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

Hi Vinod,

On Tue, Dec 15, 2015 at 6:26 PM, Vinod Koul <vinod.koul@...el.com> wrote:
> On Tue, Dec 15, 2015 at 11:48:24AM +0100, Geert Uytterhoeven wrote:
>> On Fri, Jul 10, 2015 at 10:14 AM, Vinod Koul <vinod.koul@...el.com> wrote:
>> > On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
>> >> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij

(yes, 2013)

>> >> <linus.walleij@...aro.org> wrote:
>> >> > The documentation already says these are physical addresses, and
>> >> > we have concluded that any translation into the DMA address space
>> >> > needs to reside in the dmaengine driver, so change the type of
>> >> > the passed arguments.
>> >> >
>> >> > Cc: Arnd Bergmann <arnd@...db.de>
>> >> > Cc: Lee Jones <lee.jones@...aro.org>
>> >> > Cc: Vinod Koul <vinod.koul@...el.com>
>> >> > Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
>> >>
>> >> What's the status of this one, which has been acked by Lee and Arnd?
>> > Looks to have slipped thru. I will redo it
>>
>> Ping?
>
> I should be able to do this in next few days...

Ping?

This is a dependency for adding iommu support to the rcar-dmac driver, cfr.
"[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave transfers".
http://www.spinics.net/lists/linux-renesas-soc/msg00066.html
https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg00108.html

Thank you for applying!

>> >> > ---
>> >> >  include/linux/dmaengine.h | 4 ++--
>> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >> >
>> >> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
>> >> > index 91ac8da..681df5f9 100644
>> >> > --- a/include/linux/dmaengine.h
>> >> > +++ b/include/linux/dmaengine.h
>> >> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
>> >> >   */
>> >> >  struct dma_slave_config {
>> >> >         enum dma_transfer_direction direction;
>> >> > -       dma_addr_t src_addr;
>> >> > -       dma_addr_t dst_addr;
>> >> > +       phys_addr_t src_addr;
>> >> > +       phys_addr_t dst_addr;
>> >> >         enum dma_slave_buswidth src_addr_width;
>> >> >         enum dma_slave_buswidth dst_addr_width;
>> >> >         u32 src_maxburst;

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds