linux-kernel - Re: [RFC][PATCH 4/4] sched: Add debugfs/sched/deadline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160203082127.6c85aa7a@gandalf.local.home>
Date:	Wed, 3 Feb 2016 08:21:27 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Juri Lelli <juri.lelli@...il.com>,
	Clark Williams <williams@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC][PATCH 4/4] sched: Add debugfs/sched/deadline_bw file to
 show current bandwidths

On Wed, 3 Feb 2016 11:12:09 +0100
Ingo Molnar <mingo@...nel.org> wrote:

> * Peter Zijlstra <peterz@...radead.org> wrote:
> 
> > On Mon, Feb 01, 2016 at 05:38:09PM -0500, Steven Rostedt wrote:
> >   
> > > Regardless of this final patch, what do you think of the first three? I
> > > can send them as a separate series, just to get more of the SCHED_DEBUG
> > > code into debug.c.  
> > 
> > The first two looked ok, the third I had a vague niggle it might be part
> > of something bigger and tearing it up like this might make it harder.  

Actually, I originally had plans to display the entire root domain
here, but decided against that.

> 
> Yeah, so the purpose of kernel/sched/debug.c is mostly meant as a filesystem 
> interface to display various internal scheduler details. It mostly deals with 
> /proc/sched_debug details: hence the name.
> 
> Note that 'sched domain debugging' does not fit into that cleanly, because it also 
> does sanity checking of the sched-domains data. So I'm not sure we want to do 
> patch #3 that moves sched-domain debugging to debug.c.
> 
> So debug.c is named in a bit too generic fashion, attracting such patches.
> 

It was actually more the #ifdef SCHED_DEBUG that attracted the patches.
The debug.c file is compiled on SCHED_DEBUG, thus it appeared natural
to have parts in core.c just moved into that file instead of having all
the #ifdef SCHED_DEBUG in it.

-- Steve