linux-kernel - Re: [PATCH 1/5] x86/cpufeature: Carve out X86_FEATURE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <24000.1454510189@warthog.procyon.org.uk>
Date:	Wed, 03 Feb 2016 14:36:29 +0000
From:	David Howells <dhowells@...hat.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	dhowells@...hat.com, "H. Peter Anvin" <hpa@...or.com>,
	Andy Lutomirski <luto@...capital.net>,
	Brian Gerst <brgerst@...il.com>, X86 ML <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/5] x86/cpufeature: Carve out X86_FEATURE_*

Borislav Petkov <bp@...en8.de> wrote:

> In file included from arch/x86/boot/mkcpustr.c:20:0:
> arch/x86/boot/../include/asm/cpufeatures.h:4:35: fatal error: asm/required-features.h: No such file or directory
> compilation terminated.
> make[1]: *** [arch/x86/boot/mkcpustr] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [bzImage] Error 2
> make: *** Waiting for unfinished jobs....
> 
> That's when you remove the #ifndef guards.
> 
> And I think the commit above does this special dancing to keep
> cpufeature.h a kernel-only header and not make it an uapi one. David, am
> I close?

Yes.  CONFIG_ symbols should be considered verboten in UAPI headers and
cpufeature.h is all about using them.

David