linux-kernel - RE: [PATCH 14/14] x86/efi: Print size in binary units in efi_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94D0CD8314A33A4D9D801C0FE68B40295BF72A9F@G4W3202.americas.hpqcorp.net>
Date:	Wed, 3 Feb 2016 15:25:24 +0000
From:	"Elliott, Robert (Persistent Memory)" <elliott@....com>
To:	Matt Fleming <matt@...eblueprint.co.uk>,
	Ingo Molnar <mingo@...nel.org>
CC:	Laszlo Ersek <lersek@...hat.com>,
	"H . Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Taku Izumi <izumi.taku@...fujitsu.com>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: RE: [PATCH 14/14] x86/efi: Print size in binary units in
 efi_print_memmap


> -----Original Message-----
> From: Matt Fleming [mailto:matt@...eblueprint.co.uk]
> Sent: Wednesday, February 3, 2016 5:28 AM
> To: Ingo Molnar <mingo@...nel.org>
> Cc: Laszlo Ersek <lersek@...hat.com>; H . Peter Anvin <hpa@...or.com>;
> Thomas Gleixner <tglx@...utronix.de>; linux-efi@...r.kernel.org; linux-
> kernel@...r.kernel.org; Elliott, Robert (Persistent Memory)
> <elliott@....com>; Andy Shevchenko <andriy.shevchenko@...ux.intel.com>;
> Ard Biesheuvel <ard.biesheuvel@...aro.org>; Taku Izumi
> <izumi.taku@...fujitsu.com>; Linus Torvalds <torvalds@...ux-
> foundation.org>; Andrew Morton <akpm@...ux-foundation.org>
> Subject: Re: [PATCH 14/14] x86/efi: Print size in binary units in
> efi_print_memmap
...
> OK, this patch has caused enough headaches. Let's drop it from this
> series.
> 
> Robert, Andy, feel free to resubmit it after you've addressed
> everyone's concerns and we can discuss it in isolation.

We could just delete the size print altogether - better to print
nothing than a silently rounded number.  The end address already
communicates the size - it's just not as readable.  

The e820 table prints don't bother with a size print. 

That would also shorten these extremely wide prints to 116
characters (131 if printk time is enabled).

[    0.000000] BIOS-e820: [mem 0x0000001880000000-0x000000207fffffff] reserved
vs.
[    0.000000] efi: mem62: [Reserved           |   |  |NV|  |  |  |  |   |WB|WT|WC|UC] range=[0x0000001880000000-0x000000207fffffff] (32 GiB)

---
Robert Elliott, HPE Persistent Memory