linux-kernel - Re: [PATCH v6] SATA: OCTEON: support SATA on OCTEON platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1725737.t6I7PsvPbL@wuerfel>
Date:	Wed, 03 Feb 2016 16:31:23 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>
Cc:	tj@...nel.org, hdegoede@...hat.com, david.daney@...ium.com,
	aleksey.makarov@...iumnetworks.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH v6] SATA: OCTEON: support SATA on OCTEON platform

On Wednesday 03 February 2016 14:44:32 Zubair Lutfullah Kakakhel wrote:
> 
> Possible in the example.
> 
> I'll update the example to
> 
>         uctl@...006c000000 {
>                 compatible = "cavium,octeon-7130-sata-uctl";
>                 reg = <0x11800 0x6c000000 0x0 0x100>;
>                 ranges; /* Direct mapping */
>                 dma-ranges;
>                 #address-cells = <1>;
>                 #size-cells = <2>;
> 
>                 sata: sata@0 {
>                         compatible = "cavium,octeon-7130-ahci";
>                         reg = <0x16c00 0x00000000 0x0 0x200>;
>                         interrupt-parent = <&cibsata>;
>                         interrupts = <2 4>; /* Bit: 2, level */
>                 };
>         };

Sorry, I should have been clearer. What I meant is


         uctl@...006c000000 {
                compatible = "cavium,octeon-7130-sata-uctl";
                reg = <0x11800 0x6c000000 0x0 0x100>;
                ranges = <0   0x16c00 0x00000000   0xffffffff>;
                dma-ranges;
                #address-cells = <1>;
                #size-cells = <1>;

                sata: sata@0 {
                        compatible = "cavium,octeon-7130-ahci";
                        reg = <0x00000000 0x200>;
                        interrupt-parent = <&cibsata>;
                        interrupts = <2 4>; /* Bit: 2, level */
                };
        };


However, I realized that this would break the dma-ranges, if the
child device is indeed 64-bit DMA capable. When #address-cells and/or
#size-cells don't match between parent and child, you have to provide
non-empty ranges as well as dma-ranges, and the dma-ranges for
#address-cells=<1> would imply only supporting 32-bit DMA.


It could still be

         uctl@...006c000000 {
                compatible = "cavium,octeon-7130-sata-uctl";
                reg = <0x11800 0x6c000000 0x0 0x100>;
                ranges = <0 0  0x16c00 0x00000000   1 0>;
                dma-ranges;
                #address-cells = <1>;
                #size-cells = <1>;

                sata: sata@0 {
                        compatible = "cavium,octeon-7130-ahci";
                        reg = <0 0  0x200>;
                        interrupt-parent = <&cibsata>;
                        interrupts = <2 4>; /* Bit: 2, level */
                };
        };

to have a ranges property that shows we are only translating one 4GB
segment of MMIO addresses into the child, but that the child has DMA
access to the entire CPU address space (including 64-bit wide RAM
as well as all MMIO).

	Arnd