linux-kernel - Re: [PATCH v3 4/4] ARM64: dts: rockchip: add syscon-reboot-mode DT node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56B160F6.20308@rock-chips.com>
Date:	Wed, 3 Feb 2016 10:07:50 +0800
From:	Shawn Lin <shawn.lin@...k-chips.com>
To:	Andy Yan <andy.yan@...k-chips.com>, john.stultz@...aro.org
Cc:	robh+dt@...nel.org, arnd@...db.de, shawn.lin@...k-chips.com,
	mark.rutland@....com, heiko@...ech.de, catalin.marinas@....com,
	will.deacon@....com, linux-kernel@...r.kernel.org,
	alexandre.belloni@...e-electrons.com, lorenzo.pieralisi@....com,
	linux@....linux.org.uk, dbaryshkov@...il.com, richard@....at,
	linux-pm@...r.kernel.org, linux-rockchip@...ts.infradead.org,
	wxt@...k-chips.com, devicetree@...r.kernel.org, pawel.moll@....com,
	ijc+devicetree@...lion.org.uk, matthias.bgg@...il.com,
	linux-arm-kernel@...ts.infradead.org, moritz.fischer@...us.com,
	mbrugger@...e.com, sre@...nel.org, galak@...eaurora.org,
	jun.nie@...aro.org, dwmw2@...radead.org
Subject: Re: [PATCH v3 4/4] ARM64: dts: rockchip: add syscon-reboot-mode DT
 node

On 2016/2/2 18:13, Andy Yan wrote:
> Add syscon-reboot-mode driver DT node for rk3368 platform
>
> Signed-off-by: Andy Yan <andy.yan@...k-chips.com>
>

Work fine with my rk3368-sheep board :)

Tested-by: Shawn Lin <shawn.lin@...k-chips.com>

> ---
>
> Changes in v3:
> - descirbe all reboot mode as property instead of subnode
>
> Changes in v2:
> - make this node as a subnode of pmugrf
>
> Changes in v1: None
>
>   arch/arm64/boot/dts/rockchip/rk3368.dtsi | 14 +++++++++++++-
>   1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> index 122777b..5213713 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> @@ -45,6 +45,7 @@
>   #include <dt-bindings/interrupt-controller/irq.h>
>   #include <dt-bindings/interrupt-controller/arm-gic.h>
>   #include <dt-bindings/pinctrl/rockchip.h>
> +#include <dt-bindings/soc/rockchip_boot-mode.h>
>   #include <dt-bindings/thermal/thermal.h>
>
>   / {
> @@ -554,8 +555,19 @@
>   	};
>
>   	pmugrf: syscon@...38000 {
> -		compatible = "rockchip,rk3368-pmugrf", "syscon";
> +		compatible = "rockchip,rk3368-pmugrf", "syscon", "simple-mfd";
>   		reg = <0x0 0xff738000 0x0 0x1000>;
> +
> +		reboot-mode {
> +			compatible = "syscon-reboot-mode";
> +			offset = <0x200>;
> +			mode-normal = <BOOT_NORMAL>;
> +			mode-recovery = <BOOT_RECOVERY>;
> +			mode-fastboot = <BOOT_FASTBOOT>;
> +			mode-loader = <BOOT_LOADER>;
> +			mode-maskrom = <BOOT_MASKROM>;
> +
> +		};
>   	};
>
>   	cru: clock-controller@...60000 {
>


-- 
Best Regards
Shawn Lin