linux-kernel - Re: [PATCH v6] SATA: OCTEON: support SATA on OCTEON platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8562433.7oWe1ikqcL@wuerfel>
Date:	Wed, 03 Feb 2016 17:23:18 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>
Cc:	tj@...nel.org, hdegoede@...hat.com, david.daney@...ium.com,
	aleksey.makarov@...iumnetworks.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH v6] SATA: OCTEON: support SATA on OCTEON platform

On Wednesday 03 February 2016 16:02:05 Zubair Lutfullah Kakakhel wrote:

> Hence, I find the original binding simpler and easier to understand when looking at the hardware manual
> 
> +       uctl@...006c000000 {
> +               compatible = "cavium,octeon-7130-sata-uctl";
> +               reg = <0x11800 0x6c000000 0x0 0x100>;
> +               ranges; /* Direct mapping */
> +               dma-ranges;
> +               #address-cells = <2>;
> +               #size-cells = <2>;
> +
> +               sata: sata@...0000000000 {
> +                       compatible = "cavium,octeon-7130-ahci";
> +                       reg = <0x16c00 0x00000000 0x0 0x200>;
> +                       interrupt-parent = <&cibsata>;
> +                       interrupts = <2 4>; /* Bit: 2, level */
> +               };
> +       };
> 
> Is it possible to let this example go in as is?
> 

I don't have the hardware manual, so I'm just guessing what the hardware
looks like. If the manual describes the device as a bridge with a 1:1 mapping,
then your existing example above absolutely makes sense.

	Arnd