linux-kernel - Re: [PATCH] kernel/cpu: Distinctive name for cpu_hotplug.dep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 3 Feb 2016 22:42:44 +0530
From:	Gautham R Shenoy <ego@...ux.vnet.ibm.com>
To:	Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>
Cc:	Linux kernel development <linux-kernel@...r.kernel.org>,
	"Gautham R. Shenoy" <ego@...ux.vnet.ibm.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Intel graphics driver community testing & development 
	<intel-gfx@...ts.freedesktop.org>
Subject: Re: [PATCH] kernel/cpu: Distinctive name for cpu_hotplug.dep_map

Hello Joonas,

On Wed, Feb 03, 2016 at 04:24:28PM +0200, Joonas Lahtinen wrote:
> Use distinctive name for cpu_hotplug.dep_map to avoid the actual
> cpu_hotplug.lock appearing as cpu_hotplug.lock#2 in lockdep splats.
> 
> Cc: Gautham R. Shenoy <ego@...ux.vnet.ibm.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Cc: Intel graphics driver community testing & development <intel-gfx@...ts.freedesktop.org>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>
> ---
>  kernel/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index 5b9d396..6a13f24 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -78,7 +78,7 @@ static struct {
>  	.wq = __WAIT_QUEUE_HEAD_INITIALIZER(cpu_hotplug.wq),
>  	.lock = __MUTEX_INITIALIZER(cpu_hotplug.lock),
>  #ifdef CONFIG_DEBUG_LOCK_ALLOC
> -	.dep_map = {.name = "cpu_hotplug.lock" },
> +	.dep_map = STATIC_LOCKDEP_MAP_INIT("cpu_hotplug.dep_map", &cpu_hotplug.dep_map),

Looks good to me!
Acked-by: Gautham R. Shenoy <ego@...ux.vnet.ibm.com>

--
Thanks and Regards
gautham.