linux-kernel - Re: [PATCH][v2] drivers/memory: Add deep sleep support for IFC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADRPPNRjdWcqdALo_AW-k=0pYnkbd69nHyLBJHr66r9o6oaEZw@mail.gmail.com>
Date:	Thu, 4 Feb 2016 17:24:59 -0600
From:	Li Yang <leoli@...escale.com>
To:	Raghav Dogra <raghav@...escale.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>, oss@...error.net,
	prabhakar.kushwaha@....com,
	Prabhakar Kushwaha <prabhakar@...escale.com>
Subject: Re: [PATCH][v2] drivers/memory: Add deep sleep support for IFC

On Fri, Jan 8, 2016 at 5:18 AM, Raghav Dogra <raghav@...escale.com> wrote:
> Add support of suspend, resume function to support deep sleep.
> Also make sure of SRAM initialization  during resume.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar@...escale.com>
> Signed-off-by: Raghav Dogra <raghav@...escale.com>
> ---
> Changes for v2: Copying only the correct registers while resume.
> Based on git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git
> branch "next"
>
>  drivers/memory/fsl_ifc.c | 163 +++++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/fsl_ifc.h  |   6 ++
>  2 files changed, 169 insertions(+)
>
{snip}
> +               ifc_out32(ncfgr | IFC_NAND_SRAM_INIT_EN,
> +                                       &ifc->ifc_nand.ncfgr);
> +               /* wait for  SRAM_INIT bit to be clear or timeout */
> +               status = spin_event_timeout(

This spin_event_timeout() API is only defined by powerpc and is not
supposed to be used in a generic driver.  How did you pass the build
on arm/arm64?

Regards,
Leo