linux-kernel - Re: [PATCH v4 09/43] usb: gadget: composite: handle function bind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 4 Feb 2016 13:42:56 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Robert Baldyga <r.baldyga@...sung.com>
Cc:	kbuild-all@...org, balbi@...com, gregkh@...uxfoundation.org,
	andrzej.p@...sung.com, m.szyprowski@...sung.com,
	b.zolnierkie@...sung.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Robert Baldyga <r.baldyga@...sung.com>
Subject: Re: [PATCH v4 09/43] usb: gadget: composite: handle function bind

Hi Robert,

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v4.5-rc2 next-20160203]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Robert-Baldyga/usb-gadget-composite-introduce-new-function-API/20160203-205850
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   include/linux/usb/gadget.h:227: warning: No description found for parameter 'claimed'
   include/linux/usb/gadget.h:227: warning: No description found for parameter 'enabled'
   include/linux/usb/gadget.h:652: warning: No description found for parameter 'quirk_altset_not_supp'
   include/linux/usb/gadget.h:652: warning: No description found for parameter 'quirk_stall_not_supp'
   include/linux/usb/gadget.h:652: warning: No description found for parameter 'quirk_zlp_not_supp'
   include/linux/usb/composite.h:114: warning: No description found for parameter 'ss_comp'
   include/linux/usb/composite.h:141: warning: No description found for parameter 'alt'
   include/linux/usb/composite.h:691: warning: Excess struct/union/enum/typedef member 'setup_pending' description in 'usb_composite_dev'
   include/linux/usb/composite.h:691: warning: Excess struct/union/enum/typedef member 'os_desc_pending' description in 'usb_composite_dev'
>> drivers/usb/gadget/composite.c:2437: warning: No description found for parameter 'ep1'
>> drivers/usb/gadget/composite.c:2437: warning: No description found for parameter 'ep2'
   drivers/usb/gadget/function/f_acm.c:1: warning: no structured comments found
   drivers/usb/gadget/function/f_ecm.c:1: warning: no structured comments found
   drivers/usb/gadget/function/f_subset.c:1: warning: no structured comments found
   drivers/usb/gadget/function/f_obex.c:1: warning: no structured comments found
   drivers/usb/gadget/function/f_serial.c:1: warning: no structured comments found

vim +/ep1 +2437 drivers/usb/gadget/composite.c

  2421			usb_ep_free_request(cdev->gadget->ep0, cdev->req);
  2422		}
  2423		cdev->next_string_id = 0;
  2424		device_remove_file(&cdev->gadget->dev, &dev_attr_suspended);
  2425	}
  2426	
  2427	/**
  2428	 * usb_cmp_ep_descs - compare descriptors of two endpoints
  2429	 *
  2430	 * As currently during autoconfig procedure we take into consideration only
  2431	 * FullSpeed and SuperSpeed Companion descriptors, we need to compare only
  2432	 * these descriptors. It they are the same, endpoints are identical from
  2433	 * autoconfig point of view.
  2434	 */
  2435	static int usb_cmp_ep_descs(struct usb_composite_ep *ep1,
  2436			struct usb_composite_ep *ep2)
> 2437	{
  2438		if (ep1->fs.desc->bLength != ep2->fs.desc->bLength)
  2439			return 0;
  2440		if (usb_endpoint_dir_in(ep1->fs.desc) ^
  2441				usb_endpoint_dir_in(ep2->fs.desc))
  2442			return 0;
  2443		if (ep1->fs.desc->bmAttributes != ep2->fs.desc->bmAttributes)
  2444			return 0;
  2445		if (ep1->fs.desc->wMaxPacketSize != ep2->fs.desc->wMaxPacketSize)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (6229 bytes)