linux-kernel - Re: [PATCH 2/2] net/smscx5xx: use the device tree for mac address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40411294.EnLd2i85mo@wuerfel>
Date:	Thu, 04 Feb 2016 09:24 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Lubomir Rintel <lkundrak@...sk>
Cc:	linux-rpi-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Peter Chen <peter.chen@...escale.com>,
	Olivier Blin <dev@...no.org>,
	Stephen Warren <swarren@...dotorg.org>,
	popcornmix <popcornmix@...il.com>
Subject: Re: [PATCH 2/2] net/smscx5xx: use the device tree for mac address

On Thursday 04 February 2016 08:36:04 Lubomir Rintel wrote:
> 
> [lkundrak@...sk: updated to use of_get_property() as per suggestion from Arnd,
> reworded the message and comments a bit]
> 
> Tested-by: Lubomir Rintel <lkundrak@...sk>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> 

Looks good to me now. We could debate which MAC address should
be used when both EEPROM and DT exist. The current version prefers
the EEPROM address, and I think some other drivers do the opposite,
but I don't really know which is best.

	Arnd