linux-kernel - Re: [PATCH 6/6] ibmvscsi: Add endian conversions to sysfs attribute show functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160204084552.GY27969@c203.arch.suse.de>
Date:	Thu, 4 Feb 2016 09:45:52 +0100
From:	Johannes Thumshirn <jthumshirn@...e.de>
To:	Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>
Cc:	JBottomley@...n.com, martin.petersen@...cle.com,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, nfont@...ux.vnet.ibm.com,
	brking@...ux.vnet.ibm.com, hare@...e.de
Subject: Re: [PATCH 6/6] ibmvscsi: Add endian conversions to sysfs attribute
 show functions

On Wed, Feb 03, 2016 at 05:28:34PM -0600, Tyrel Datwyler wrote:
> The values returned by the show functions for the host os_type,
> mad_version, and partition_number attributes get their values
> directly from the madapter_info struct whose associated fields are
> __be32 typed. Added endian conversion to ensure these values are
> sane on LE platforms.
> 
> Signed-off-by: Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>
> ---
>  drivers/scsi/ibmvscsi/ibmvscsi.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index a2b8db1..3621ac5 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -1983,7 +1983,7 @@ static ssize_t show_host_partition_number(struct device *dev,
>  	int len;
>  
>  	len = snprintf(buf, PAGE_SIZE, "%d\n",
> -		       hostdata->madapter_info.partition_number);
> +		       be32_to_cpu(hostdata->madapter_info.partition_number));
>  	return len;
>  }
>  
> @@ -2003,7 +2003,7 @@ static ssize_t show_host_mad_version(struct device *dev,
>  	int len;
>  
>  	len = snprintf(buf, PAGE_SIZE, "%d\n",
> -		       hostdata->madapter_info.mad_version);
> +		       be32_to_cpu(hostdata->madapter_info.mad_version));
>  	return len;
>  }
>  
> @@ -2022,7 +2022,8 @@ static ssize_t show_host_os_type(struct device *dev,
>  	struct ibmvscsi_host_data *hostdata = shost_priv(shost);
>  	int len;
>  
> -	len = snprintf(buf, PAGE_SIZE, "%d\n", hostdata->madapter_info.os_type);
> +	len = snprintf(buf, PAGE_SIZE, "%d\n",
> +		       be32_to_cpu(hostdata->madapter_info.os_type));
>  	return len;
>  }
>  
> -- 
> 2.5.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de>
-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850