linux-kernel - Re: [PATCH] scripts/sign-file.c: Add support for signing with a raw signature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24880.1454582552@warthog.procyon.org.uk>
Date:	Thu, 04 Feb 2016 10:42:32 +0000
From:	David Howells <dhowells@...hat.com>
To:	Juerg Haefliger <juerg.haefliger@....com>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org,
	keyrings@...r.kernel.org, dwmw2@...radead.org
Subject: Re: [PATCH] scripts/sign-file.c: Add support for signing with a raw signature

Juerg Haefliger <juerg.haefliger@....com> wrote:

> >> +static EVP_PKEY *read_private_key(char *private_key_name)
> > 
> > const char * please.
> > 
> >> +static X509 *read_x509(char *x509_name)
> > 
> > And here.
> 
> Why? These functions do return pointers to EVP_PKEY and X509 structs.

I meant the arguments not the return type.

David