linux-kernel - Re: [PATCH][V2] IB/sysfs: remove unused va

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 4 Feb 2016 07:12:43 -0500
From:	Doug Ledford <dledford@...hat.com>
To:	Colin King <colin.king@...onical.com>,
	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Christoph Lameter <cl@...ux.com>,
	Matan Barak <matanb@...lanox.com>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	Or Gerlitz <ogerlitz@...lanox.com>, linux-rdma@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, kernel-team@...ntu.com
Subject: Re: [PATCH][V2] IB/sysfs: remove unused va_list args

On 01/25/2016 01:38 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> _show_port_gid_attr performs a va_end on some unused va_list args.
> Clean this up by removing the args completely.
> 
> Fixes: 470be516a226e8 ("IB/core: Add gid attributes to sysfs")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/infiniband/core/sysfs.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
> index 3de9351..ec46386 100644
> --- a/drivers/infiniband/core/sysfs.c
> +++ b/drivers/infiniband/core/sysfs.c
> @@ -336,7 +336,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
>  	union ib_gid gid;
>  	struct ib_gid_attr gid_attr = {};
>  	ssize_t ret;
> -	va_list args;
>  
>  	ret = ib_query_gid(p->ibdev, p->port_num, tab_attr->index, &gid,
>  			   &gid_attr);
> @@ -348,7 +347,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
>  err:
>  	if (gid_attr.ndev)
>  		dev_put(gid_attr.ndev);
> -	va_end(args);
>  	return ret;
>  }
>  
> 

Thanks, applied.

-- 
Doug Ledford <dledford@...hat.com>
              GPG KeyID: 0E572FDD



Download attachment "signature.asc" of type "application/pgp-signature" (885 bytes)