linux-kernel - Re: [RFT PATCH] powerpc: convert amigaone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <2550250.nXgBuiRPBT@amdc1976>
Date:	Thu, 04 Feb 2016 15:35:08 +0100
From:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:	Gerhard Pircher <gerhard_pircher@....net>
Cc:	linuxppc-dev@...ts.ozlabs.org,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Michael Ellerman <mpe@...erman.id.au>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFT PATCH] powerpc: convert amigaone_defconfig to use libata PATA
 drivers


Hi,

On Wednesday, February 03, 2016 10:17:51 PM Gerhard Pircher wrote:
> Am 2016-02-03 um 16:50 schrieb Bartlomiej Zolnierkiewicz:
> > IDE subsystem has been deprecated since 2009 and the majority
> > (if not all) of Linux distributions have switched to use
> > libata for ATA support exclusively.  However there are still
> > some users (mostly old or/and embedded non-x86 systems) that
> > have not converted from using IDE subsystem to libata PATA
> > drivers.  This doesn't seem to be good thing in the long-term
> > for Linux as while there is less and less PATA systems left
> > in use:
> > 
> > * testing efforts are divided between two subsystems
> > 
> > * having duplicate drivers for same hardware confuses users
> > 
> > This patch converts amigaone_defconfig to use libata PATA
> > drivers.
> > 
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> > ---
> > Build tested only.
> > If you have affected hardware please test.  Thank you.
> > 
> >  arch/powerpc/configs/amigaone_defconfig | 10 ++++------
> >  1 file changed, 4 insertions(+), 6 deletions(-)
> > 
> > diff --git a/arch/powerpc/configs/amigaone_defconfig b/arch/powerpc/configs/amigaone_defconfig
> > index 84f1b41..55a4929 100644
> > --- a/arch/powerpc/configs/amigaone_defconfig
> > +++ b/arch/powerpc/configs/amigaone_defconfig
> > @@ -46,12 +46,6 @@ CONFIG_PARPORT_PC_FIFO=y
> >  CONFIG_BLK_DEV_FD=y
> >  CONFIG_BLK_DEV_LOOP=y
> >  CONFIG_BLK_DEV_RAM=y
> > -CONFIG_IDE=y
> > -CONFIG_BLK_DEV_IDECD=y
> > -# CONFIG_IDEPCI_PCIBUS_ORDER is not set
> > -CONFIG_BLK_DEV_GENERIC=y
> > -CONFIG_BLK_DEV_SIIMAGE=y
> > -CONFIG_BLK_DEV_VIA82CXXX=y
> >  CONFIG_SCSI=y
> >  CONFIG_BLK_DEV_SD=y
> >  CONFIG_CHR_DEV_ST=y
> > @@ -62,6 +56,10 @@ CONFIG_SCSI_CONSTANTS=y
> >  CONFIG_SCSI_SYM53C8XX_2=y
> >  CONFIG_SCSI_SYM53C8XX_DMA_ADDRESSING_MODE=0
> >  # CONFIG_SCSI_SYM53C8XX_MMIO is not set
> > +CONFIG_ATA=y
> > +CONFIG_PATA_SIL680=y
> > +CONFIG_PATA_VIA=y
> > +CONFIG_ATA_GENERIC=y
> >  CONFIG_NETDEVICES=y
> >  CONFIG_VORTEX=y
> >  CONFIG_8139CP=y
> > 
> Thanks for cleaning up the defconfig file!
> 
> libata drivers work fine on the amigaone platform (tested on all three
> first-gen AmigaOne machines). BTW: could it be that CONFIG_ATA_SFF=y
> and CONFIG_ATA_BMDMA=y are missing in the patch?

Thank you for testing!

When it comes to CONFIG_ATA_SFF and CONFIG_ATA_BMDMA there is no need
to explicitly enable them because once CONFIG_ATA is enabled they both
are also enabled by default (they both have 'default y' in Kconfig).

[ defconfig changes in the patch were obtained by:
  - doing 'make amigaone_defconfig'
  - changing IDE options to libata ones using 'make menuconfig'
  - doing 'make savedefconfig'
  - doing 'diff -u arch/powerpc/configs/amigaone_defconfig defconfig'
  so there should be no missing options etc. ]

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics