linux-kernel - Re: [PATCH v6] kernel: add kcov code coverage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Feb 2016 16:07:38 +0100
From:	Dmitry Vyukov <dvyukov@...gle.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	syzkaller <syzkaller@...glegroups.com>,
	Vegard Nossum <vegard.nossum@...cle.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Tavis Ormandy <taviso@...gle.com>,
	Will Deacon <will.deacon@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Quentin Casasnovas <quentin.casasnovas@...cle.com>,
	Kostya Serebryany <kcc@...gle.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Alexander Potapenko <glider@...gle.com>,
	Kees Cook <keescook@...gle.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Sasha Levin <sasha.levin@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Drysdale <drysdale@...gle.com>,
	linux-arm-kernel@...ts.infradead.org,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Andrey Ryabinin <ryabinin.a.a@...il.com>,
	"Kirill A. Shutemov" <kirill@...temov.name>
Subject: Re: [PATCH v6] kernel: add kcov code coverage

On Tue, Feb 2, 2016 at 6:19 PM, Jiri Slaby <jslaby@...e.cz> wrote:
> On 01/25/2016, 02:00 PM, Dmitry Vyukov wrote:
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -136,6 +136,12 @@ _c_flags += $(if $(patsubst n%,, \
>>               $(CFLAGS_UBSAN))
>>  endif
>>
>> +ifeq ($(CONFIG_KCOV),y)
>> +_c_flags += $(if $(patsubst n%,, \
>> +     $(KCOV_INSTRUMENT_$(basetarget).o)$(KCOV_INSTRUMENT)y), \
>> +     $(CFLAGS_KCOV))
>
> Now that KCOV does not inherit KASAN's "n"s, I see link errors in efi
> lib with EFI_STUB:
> drivers/firmware/efi/libstub/lib.a(efi-stub-helper.o): In function
> `efi_printk':
> efi-stub-helper.c:(.text+0x13): undefined reference to
> `__sanitizer_cov_trace_pc'
> efi-stub-helper.c:(.text+0x31): undefined reference to
> `__sanitizer_cov_trace_pc'
> ...
>
> I fixed it by adding "KCOV_INSTRUMENT := n" to
>   drivers/firmware/efi/libstub/Makefile


Done in v7
Thanks for testing!