linux-kernel - Re: [PATCH v2 1/2] ftrace/module: remove ftrace module notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160204152120.GA3305@pathway.suse.cz>
Date:	Thu, 4 Feb 2016 16:21:20 +0100
From:	Petr Mladek <pmladek@...e.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Jessica Yu <jeyu@...hat.com>, Josh Poimboeuf <jpoimboe@...hat.com>,
	Seth Jennings <sjenning@...hat.com>,
	Jiri Kosina <jikos@...nel.org>,
	Vojtech Pavlik <vojtech@...e.com>,
	Miroslav Benes <mbenes@...e.cz>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Ingo Molnar <mingo@...hat.com>, live-patching@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] ftrace/module: remove ftrace module notifier

On Thu 2016-02-04 09:18:01, Steven Rostedt wrote:
> On Thu, 4 Feb 2016 14:27:51 +0100
> Petr Mladek <pmladek@...e.com> wrote:
> 
> 
> > > +	ftrace_module_enable(mod);
> > >  	blocking_notifier_call_chain(&module_notify_list,
> > >  				     MODULE_STATE_COMING, mod);
> > >  	return 0;  
> > 
> > Also we need to call ftrace_release_mod() in bug_cleanup:
> > goto target in load_module(). Otherwise, it will stay
> > enabled when, e.g. parse_args() fails.
> 
> Look farther down (after free_module:), it's already there.

Ah, I see. ftrace_release_mod() is called there on an unexpected
location. Error paths typically do actions in the reverse order
in compare with the normal paths :-)

Thanks for the pointer,
Petr