linux-kernel - Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Feb 2016 08:46:49 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Timur Tabi <timur@...eaurora.org>,
	Will Deacon <will.deacon@....com>, fu.wei@...aro.org
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org, wim@...ana.be,
	corbet@....net, catalin.marinas@....com,
	Suravee.Suthikulpanit@....com, linux-kernel@...r.kernel.org,
	linux-watchdog@...r.kernel.org, linux-doc@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linaro-acpi@...ts.linaro.org, rruigrok@...eaurora.org,
	harba@...eaurora.org, cov@...eaurora.org, dyoung@...hat.com,
	panand@...hat.com, graeme.gregory@...aro.org, al.stone@...aro.org,
	hanjun.guo@...aro.org, jcm@...hat.com, arnd@...db.de,
	leo.duran@....com, sudeep.holla@....com
Subject: Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver

On 02/04/2016 08:37 AM, Timur Tabi wrote:
> Will Deacon wrote:
>>> +static int sbsa_gwdt_keepalive(struct watchdog_device *wdd)
>>> >+{
>>> >+    struct sbsa_gwdt *gwdt = to_sbsa_gwdt(wdd);
>>> >+
>>> >+    /*
>>> >+    * Writing WRR for an explicit watchdog refresh.
>>> >+    * You can write anyting(like 0xc0ffee).
>>> >+    */
>>> >+    writel(0xc0ffee, gwdt->refresh_base + SBSA_GWDT_WRR);
>>> >+
>>> >+    return 0;
>>> >+}
>> You might get in trouble for that. 0xd09f00d is probably less poisonous.
>>
>> http://www.petpoisonhelpline.com/poison/caffeine/
>
> Any reason why we can't just keep it simple and write 0?

+1

Guenter