linux-kernel - Re: [PATCH v3.1] firmware: clean up filesystem load exit path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160204220122.GL12481@wotan.suse.de>
Date:	Thu, 4 Feb 2016 23:01:22 +0100
From:	"Luis R. Rodriguez" <mcgrof@...e.com>
To:	Kees Cook <keescook@...omium.org>
Cc:	Mimi Zohar <zohar@...ux.vnet.ibm.com>,
	"Luis R. Rodriguez" <mcgrof@...nel.org>,
	Josh Boyer <jwboyer@...oraproject.org>,
	David Howells <dhowells@...hat.com>,
	linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Dmitry Kasatkin <dmitry.kasatkin@...il.com>,
	Eric Biederman <ebiederm@...ssion.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	linux-security-module@...r.kernel.org, kexec@...ts.infradead.org,
	linux-modules@...r.kernel.org
Subject: Re: [PATCH v3.1] firmware: clean up filesystem load exit path

On Thu, Feb 04, 2016 at 01:15:02PM -0800, Kees Cook wrote:
> This makes the error and success paths more readable while trying to
> load firmware from the filesystem.
>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> Cc: Josh Boyer <jwboyer@...oraproject.org>
> Cc: David Howells <dhowells@...hat.com>
> Cc: Luis R. Rodriguez <mcgrof@...nel.org>
> Cc: Mimi Zohar <zohar@...ux.vnet.ibm.com>

Thanks,

Acked-by: Luis R. Rodriguez <mcgrof@...nel.org>

> ---
> Suggested as an alternative to "[PATCH v3 06/22] firmware: fold successful fw read early"

Mimi, feel free to pick up as a replacement in your series.

  Luis