linux-kernel - Re: [PATCH] rtc: max77686: Properly handle regmap_irq_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160204224906.GD4782@piout.net>
Date:	Thu, 4 Feb 2016 23:49:06 +0100
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Chanwoo Choi <cw00.choi@...sung.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com,
	ldewangan@...dia.com, javier@....samsung.com
Subject: Re: [PATCH] rtc: max77686: Properly handle regmap_irq_get_virq()
 error code

On 04/02/2016 at 09:26:35 +0900, Krzysztof Kozlowski wrote :
> The regmap_irq_get_virq() can return 0 or -EINVAL in error conditions
> but driver checked only for value of 0.
> 
> This could lead to a cast of -EINVAL to an unsigned int used as a
> interrupt number for devm_request_threaded_irq(). Although this is not
> yet fatal (devm_request_threaded_irq() will just fail with -EINVAL) but
> might be a misleading when diagnosing errors.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Fixes: 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq")
> 
> ---
> 
> Patch rebased on current mainline, not RTC tree, because IMHO it is
> a candidate for current RC-cycle.
> 
> Not marking cc-stable because behavior is not fatal - unless there is
> an interrupt with number 4294967274 (then it would be successfully
> requested for RTC driver).
> ---
>  drivers/rtc/rtc-max77686.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com